-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bout_v6_coordinates_upgrader script #115
Add bout_v6_coordinates_upgrader script #115
Conversation
This seems to depend on boutproject/BOUT-dev#2873 Concerning boutproject/BOUT-dev#2873 (comment) - is the use of proxy classes still considered? |
@dschwoerer It's related to those changes, but doesn't depend on them Proxy classes would be nice, but they do also have significant downsides -- more difficult to debug, and tend to be fragile. |
@ZedThree maybe we mean different things by "depend on the PR" - i meant that users would only want to use this conversion script, iff the PR is applied to their BOUT++ version. Otherwise that certainly would break the code? I think we could make v5 forward compatible by:
I misunderstood / misremembered your comment, and thought that would be intended to be part of #2873 - but now I think that is not planned? |
Add a python script that upgrades files to use the refactored Coordinates class.