Replace geqdsk reader with FreeQDSK #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were testing slices in t, x, y, z, and all four combined. The combined slices should really cover all the other cases, so we can get rid of most of them. This just removes the y and z cases, but could probably also remove the t and x ones too
This also changes it to just parameterise `mxg` and `myg` together
The majority of `collect` tests time is spent in `datafile.open`, and because we re-open the file for each field we collect, reducing the number of fields in the files gives us a big speed up
|
Maybe we should just delete these entirely? |
|
Deleted entirely in #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Includes #107)
Moved from
boututilsto here