-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIB-8227 Memory overflow #50
Open
DavidGlasgow
wants to merge
32
commits into
bostelm:master
Choose a base branch
from
DavidGlasgow:CONTRIB-8227
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no 's' in the language file
Moodle 4.0 monologo.
Update README.md and create GitHub Actions.
Correction a typo
New format for event ids, no longer including course id
Enforce that end time is larger than start time
Achieving green pill in plugins db.
CONTRIB-9214 Fix attachments not viewable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a scheduler slot in teacher view, the list of student appointments is presented to the teacher using formslib repeat_elements.
The element being replicated, at minimum, contains the following mform elements:
appointhead header
student group, which contains:
studentid searchableselector
appointid hidden
attended checkbox with label "seen"
Additionally, scheduler may add the following form elements based on configuration of the scheduler:
grade select with label "grade" to the above group
appointmentnote editor
teachernote editor
Then all appointments have
deletestudent checkbox
The header element includes the "{no}" wildcard which injects a numeric count into the Appointment header, e.g. "Appointment 1, Appointment 2 etc.."
formslib repeatelements always starts this count at zero and doesn't support paging of this numeric out of the box.
studentid as searchableselector with many available students on the course of the scheduler, can dramatically increase the RAM usage per appointment.
In testing, a representative course without grading, appointment or teacher notes, with a single slot with 89 appointments, on a course with 375 participants, generated a peak RAM of 1.3 GB, or about ~15 MB per appointment.
So we have two combining forces: The number of appointments in a single slot, multiplied by the number of participants in the course.
In my testing, changing studentid from searchableselector to autocomplete reduces the RAM footprint for each appointment that is repeated to ~2 MB to the RAM usage on the server, or for 89 appointments, 130 MB, just higher than a commonly usage php_memory_limit value of 128 MB.