Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements (watching slots, import via CSV, mobile support, ...) #42

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

FMCorz
Copy link

@FMCorz FMCorz commented Mar 31, 2020

Hi,

The Royal College of Art have sponsored the development of additional features in the Scheduler module and wished to share those back. Here is a rather large pull request which includes them all for your consideration.

We attempted to minimise the impact of these changes on the existing code in order to facilitate its integration in the main repository. We purposely did not refactor some areas of the code and opted for duplicated logic to avoid adding regressions, and added complexity.

Here is a list of the features which were included:

  • Additional Activity completion criterion based on attendance
  • Importing slots from a CSV file
  • Revoking individuals out of a group slot
  • Adding support for sorting the list of slots
  • Adding support for filtering the list of slots
  • Give the ability for students to watch slots that are full, and receive a notification when they become available. The number of slots that can be watched at the same time is customisable.
  • Mobile support for teachers to view slots, grade and mark attendance
  • Mobile support for students to view and book slots. (Except for bookings requiring file upload)

Thank you for your consideration.

This was developed and tested on Moodle 3.7 and is currently used in production with Moodle 3.8.

@FMCorz FMCorz changed the title Several improvements (watching slots, import via CSV, ...) Several improvements (watching slots, import via CSV, mobile support, ...) Mar 31, 2020
@jtsafran
Copy link

@bostelm Thoughts on integrating this into master? The use of this in mobile would be awesome!

@ptramonti
Copy link

We are also interested in the integration into the master! Can we know if it is your intentions?

@bostelm
Copy link
Owner

bostelm commented Aug 13, 2021

Hello all,
first, thanks a lot for sharing your work. Second, I'm sorry for not responding earlier - time pressures due to the pandemic meant that I wasn't able to prepare a new major release of Scheduler (which is where this would go). Third, yes, I'm interested in integrating this (possibly in parts). I hope I can look at it soon. Meanwhile, if you could rebase the patch to current master - it's been a while - that would be helpful.

@ptramonti
Copy link

Hello,
any news on this integration?

@lucaboesch
Copy link
Contributor

@FMCorz any chance those improvements could still be shared back, even if it has been some time ago?

Best,
Luca

@FMCorz
Copy link
Author

FMCorz commented Nov 28, 2022

Hi @lucaboesch,

The improvements have been shared back a while ago. It is unfortnate that they haven't been integrated yet, but at the moment I am unable to invest the time required to properly rebase the branch and test all of the added features.

Kind regards,
Fred

@FMCorz
Copy link
Author

FMCorz commented Aug 14, 2023

I meant to leave a comment here a few months ago, but apparently I forgot to publish it. The branch had been rebased. And more changes are pending in a separate branch.

@FMCorz
Copy link
Author

FMCorz commented Sep 14, 2023

This branch (rca) and rca-more have together been rebased on master in rca-more-rebased.

@Buda9
Copy link

Buda9 commented Jul 16, 2024

Thank you so much for this @FMCorz. Love this PR and your products! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants