feat: handle binary buffers with messageBuffer
#3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is well described here: Julien-R44/bentocache#19
Basically: when using a custom encoder which returns a buffer with binary data, then it will not work. because the
message
event emitted by ioredis automatically converts buffersWhen dealing with binary data then
ioredis
recommends using themessageBuffer
event: https://github.com/redis/ioredis?tab=readme-ov-file#pubsubSuggested solution: when we create our bus with the redis transport, we can now pass the
useMessageBuffer
option which will make the bus listen on themessageBuffer
event rather thanmessage
.Breaking Change: The encoder signature has changed. The
decode
function now accepts astring
or aBuffer
. I think we can release that this in a minor release, since i think nobody has created a custom encoder yet.