Skip to content

Commit

Permalink
clearning beanutils dependency
Browse files Browse the repository at this point in the history
... it is optional for our scenarious, but it adds a security issue via
transitive dependency on commons-collections:3.2.2
  • Loading branch information
andrus committed Apr 19, 2024
1 parent afad500 commit 06e4726
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
4 changes: 0 additions & 4 deletions bootique-shiro/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@
<groupId>org.apache.shiro</groupId>
<artifactId>shiro-core</artifactId>
</dependency>
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
Expand Down
10 changes: 3 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -78,20 +78,16 @@
<groupId>org.apache.shiro</groupId>
<artifactId>shiro-core</artifactId>
<version>${shiro.version}</version>
<!-- Excluding duplicates... -->
<!-- Excluding things that are already in Bootique, Shiro "duplicates", and optional dependencies. -->
<!-- E.g. "commons-beanutils" doesn't seem useful in the context of Bootique, but there's a security issue -->
<!-- with the underlying commons-collections:3.2.2 -->
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
<!-- As a result of the Shiro exclusions above we need to add this one explicitly-->
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils</artifactId>
<version>1.9.4</version>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
Expand Down

0 comments on commit 06e4726

Please sign in to comment.