Skip to content

Commit

Permalink
getting rid of explicit compile scope declaration for readability
Browse files Browse the repository at this point in the history
  • Loading branch information
andrus committed Apr 29, 2024
1 parent ea35bf4 commit 754073f
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 24 deletions.
2 changes: 0 additions & 2 deletions bootique-jersey-beanvalidation/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,10 @@
<groupId>io.bootique.jersey</groupId>
<artifactId>bootique-jersey</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.ext</groupId>
<artifactId>jersey-bean-validation</artifactId>
<scope>compile</scope>
</dependency>

<!-- Unit test dependencies -->
Expand Down
3 changes: 0 additions & 3 deletions bootique-jersey-client-instrumented/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,14 @@
<groupId>io.bootique.jersey</groupId>
<artifactId>bootique-jersey-client</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.bootique.metrics</groupId>
<artifactId>bootique-metrics</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.bootique.metrics</groupId>
<artifactId>bootique-metrics-healthchecks</artifactId>
<scope>compile</scope>
</dependency>

<!-- Unit test dependencies -->
Expand Down
3 changes: 0 additions & 3 deletions bootique-jersey-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,14 @@
<dependency>
<groupId>io.bootique</groupId>
<artifactId>bootique</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-client</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.inject</groupId>
<artifactId>jersey-hk2</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.connectors</groupId>
Expand Down
2 changes: 0 additions & 2 deletions bootique-jersey-jackson/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,10 @@
<groupId>io.bootique.jersey</groupId>
<artifactId>bootique-jersey</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.media</groupId>
<artifactId>jersey-media-json-jackson</artifactId>
<scope>compile</scope>
</dependency>
<!--
Dependency resolution is the heart of this module. We need to ensure that Jersey's Jackson libraries
Expand Down
2 changes: 0 additions & 2 deletions bootique-jersey-jakarta-beanvalidation/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,10 @@
<groupId>io.bootique.jersey</groupId>
<artifactId>bootique-jersey-jakarta</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.ext</groupId>
<artifactId>jersey-bean-validation</artifactId>
<scope>compile</scope>
</dependency>

<!-- Unit test dependencies -->
Expand Down
3 changes: 0 additions & 3 deletions bootique-jersey-jakarta-client-instrumented/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,14 @@
<groupId>io.bootique.jersey</groupId>
<artifactId>bootique-jersey-jakarta-client</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.bootique.metrics</groupId>
<artifactId>bootique-metrics</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.bootique.metrics</groupId>
<artifactId>bootique-metrics-healthchecks</artifactId>
<scope>compile</scope>
</dependency>

<!-- Unit test dependencies -->
Expand Down
2 changes: 0 additions & 2 deletions bootique-jersey-jakarta-jackson/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,10 @@
<groupId>io.bootique.jersey</groupId>
<artifactId>bootique-jersey-jakarta</artifactId>
<version>${project.version}</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.media</groupId>
<artifactId>jersey-media-json-jackson</artifactId>
<scope>compile</scope>
</dependency>
<!--
Dependency resolution is the heart of this module. We need to ensure that Jersey's Jackson libraries
Expand Down
7 changes: 0 additions & 7 deletions bootique-jersey/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -162,42 +162,35 @@
<dependency>
<groupId>io.bootique</groupId>
<artifactId>bootique</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>io.bootique.jetty</groupId>
<artifactId>bootique-jetty</artifactId>
<scope>compile</scope>
</dependency>
<!-- java 10 and onwards requires this dependency -->
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<scope>compile</scope>
</dependency>
<!-- java 10 and onwards requires this dependency -->
<dependency>
<groupId>com.sun.activation</groupId>
<artifactId>jakarta.activation</artifactId>
<scope>compile</scope>
</dependency>
<!-- Adding a few Jersey dependencies explicitly to exclude their repackaged libraries conflicting with Guice.
TODO: there's no more Guice around
-->
<dependency>
<groupId>org.glassfish.jersey.containers</groupId>
<artifactId>jersey-container-servlet</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.core</groupId>
<artifactId>jersey-common</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.glassfish.jersey.inject</groupId>
<artifactId>jersey-hk2</artifactId>
<scope>compile</scope>
</dependency>

<!-- Unit test dependencies -->
Expand Down

0 comments on commit 754073f

Please sign in to comment.