-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flushing support for gzip compressor #116
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #116 +/- ##
===========================================
+ Coverage 68.96% 69.00% +0.04%
===========================================
Files 80 80
Lines 3444 3462 +18
Branches 1027 1033 +6
===========================================
+ Hits 2375 2389 +14
+ Misses 452 451 -1
- Partials 617 622 +5
Continue to review full report at Codecov.
|
Hey @jeking3, can you kindly review this PR |
Yeet this please Worth noting, I guess, that you can use new/delete to force the desired behavior. Any chance to generalize this for the other compressors? I'll have a look at how hard it is to add zstd. |
Uses Z_FULL_FLUSH at the point where flushing is done. Therefore it enables the user to read data between any two flush points.
Fixes 1656 for Gzip Filters. More context here
Relies on Z_BUF_ERROR to determine when to stop deflating.