Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Verifier Improvements #1147

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

javiertoledo
Copy link
Member

@javiertoledo javiertoledo commented Aug 2, 2022

Rework #1111 to adapt the changes to the new TokenVerifier interface and class structures.

  • Replaces jsonwebtoken and jwks-rsa dependencies with jose because jose has zero dependencies.
  • Adds a new EncryptedTokenVerifier token verifier implementation which can be used to decrypt JWE tokens. This can be useful when using libraries like NextAuth.js.
  • Given the higher level of abstraction of jose, the JWT utility methods are no longer needed and have been removed.

Pending before closing this PR:

  • Fix tests and verify they're all passing
  • Update the documentation with the affected changes (removal of the JWT utilities and creation of the new EncryptedTokenVerifier class).

Javier Toledo added 2 commits August 5, 2022 16:21
…nverifier-issuer

# Conflicts:
#	package-lock.json
#	packages/framework-core/src/booster-token-verifier.ts
#	packages/framework-types/src/concepts/token-verifier-config.ts
@javiertoledo javiertoledo force-pushed the feature/optional-tokenverifier-issuer branch from 180a304 to 3de75ec Compare August 5, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants