Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 모각코 게시글 작성 폼 유효성 검사 #152

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

LEEJW1953
Copy link
Collaborator

@LEEJW1953 LEEJW1953 commented Nov 23, 2023

설명

완료한 기능 명세

  • 모각코 게시글 작성 폼 유효성 검사

스크린샷

_2023_11_23_16_13_48_767.mp4

리뷰 요청 사항

특별히 리뷰해 주었으면 하는 부분, 고민되는 부분 기재하기

@LEEJW1953 LEEJW1953 self-assigned this Nov 23, 2023
@LEEJW1953 LEEJW1953 linked an issue Nov 23, 2023 that may be closed by this pull request
3 tasks
@@ -0,0 +1,36 @@
export const MOGACO_POST = {
TITLE: {
PLACEHOLDER: '모각코 함께해요',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p2; 제목 플레이스홀더 변경해 주실 수 있나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b22574e
수정하였습니다

TITLE: {
PLACEHOLDER: '모각코 함께해요',
REQUIRED: '제목을 입력해주세요',
MAX: '최대 64자 까지 입력 가능합니다',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MAX: '최대 64자 까지 입력 가능합니다',
MAX: '최대 64자까지 입력 가능합니다',

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b22574e
수정하였습니다

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

객체로 관리하는 것은 좋네요~!

GROUP: { LABEL: '그룹', REQUIRED: '그룹을 선택해주세요' },
COUNT: {
LABEL: '최대 인원 수',
PLACEHOLDER: '20',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3; 여기도 바꿔주세요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b22574e
수정하였습니다

onChange={onChange}
/>
<div className={styles.count}>
{value ? value.length : 0}/{MOGACO_POST.TITLE.MAX_LENGTH}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{value ? value.length : 0}/{MOGACO_POST.TITLE.MAX_LENGTH}
{value.?length || 0}/{MOGACO_POST.TITLE.MAX_LENGTH}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b660c32
수정하였습니다

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 데도 바꿀 수 있을 것 같아요~!

Comment on lines +16 to +41
export type Mogaco = Pick<
MogacoTypes,
| 'id'
| 'groupId'
| 'memberId'
| 'title'
| 'contents'
| 'date'
| 'participantList'
| 'maxHumanCount'
| 'address'
| 'status'
>;

export type MogacoPostForm = Pick<
MogacoTypes,
| 'title'
| 'memberId'
| 'groupId'
| 'contents'
| 'date'
| 'maxHumanCount'
| 'address'
>;

export type Participant = Pick<MogacoTypes, 'id' | 'nickname' | 'profile'>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ttaerrim ttaerrim merged commit e748923 into boostcampwm2023:develop Nov 23, 2023
1 check passed
@LEEJW1953 LEEJW1953 deleted the fe-post-form branch November 24, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 모각코 게시글 작성 페이지 구현
2 participants