[Feat] 모각코 게시글 작성 페이지 퍼블리싱 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
광기의 모각코 모집 글 |
ttaerrim
reviewed
Nov 22, 2023
Comment on lines
+26
to
+38
| const [inputCount, setInputCount] = useState<number>(0); | ||
| const inputRef = useRef<HTMLInputElement | null>(null); | ||
|
|
||
| const handleInput = () => { | ||
| if (inputRef && inputRef.current) { | ||
| setInputCount(inputRef.current.value.length); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
p3; 이 부분도 아마 react-hook-form 적용하면서 props로 받아서 처리할 수 있게 바뀔 것 같네요!
LEEJW1953
force-pushed
the
fe-mogaco-post
branch
from
a52971a to
e8dd261
Compare
js43o
reviewed
Nov 22, 2023
js43o
reviewed
Nov 22, 2023
ttaerrim
reviewed
Nov 22, 2023
Comment on lines
+12
to
+13
| min?: number | string; | ||
| max?: number; |
There was a problem hiding this comment.
p3; input type이 여러 가지가 될 수 있으니 props가 복잡해질 수도 있겠군요. 타입스크립트를 잘 적용할 수 있다면 type에 따라서도 props를 활용할 수 있지 않을까 싶네요. 한번 찾아봐야겠어요
js43o
reviewed
Nov 22, 2023
LEEJW1953
force-pushed
the
fe-mogaco-post
branch
from
372016a to
4f66d57
Compare
기본값으로 현재 시각 표시, 오늘 날짜 이후로 선택 가능하도록 제한
rows 속성을 props로 받아서 사용하도록 수정
dayjs 사용
LEEJW1953
force-pushed
the
fe-mogaco-post
branch
from
54cec74 to
132ee83
Compare
ttaerrim
approved these changes
Nov 22, 2023
js43o
approved these changes
Nov 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
완료한 기능 명세
스크린샷
_2023_11_22_18_07_58_139.mp4
리뷰 요청 사항