Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] layout 컴포넌트 maxWidth 설정 #128

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[Design] layout 컴포넌트 maxWidth 설정 #128

merged 2 commits into from
Nov 21, 2023

Conversation

ttaerrim
Copy link
Member

@ttaerrim ttaerrim commented Nov 21, 2023 •
edited
Loading

설명

  • closed [FEATURE] Layout 컴포넌트 수정 #126
  • 프론트엔드 레이아웃 통일성을 맞추기 위해 Layout에 maxWidth 설정을 추가합니다.
  • 1200px 이하 레이아웃을 위해 양옆 패딩을 추가했습니다. [1]

완료한 기능 명세

  • layout 컴포넌트 스타일 설정

스크린샷

기능 작업에 대한 스크린샷/화면 녹화 있을 경우 첨부하기

스크린샷 2023-11-21 15 59 48

2023-11-21.17.56.46.mov

리뷰 요청 사항

특별히 리뷰해 주었으면 하는 부분, 고민되는 부분 기재하기

@ttaerrim ttaerrim self-assigned this Nov 21, 2023
ttaerrim
ttaerrim commented Nov 21, 2023
View reviewed changes
Copy link
Member Author

@ttaerrim ttaerrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1ff6413 레이아웃에 양옆 패딩을 추가했습니다. 확인 부탁드려요!

@ttaerrim ttaerrim merged commit c128e40 into boostcampwm2023:develop Nov 21, 2023
1 check passed
@ttaerrim ttaerrim deleted the layout branch November 21, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEEJW1953 LEEJW1953 LEEJW1953 approved these changes

@js43o js43o js43o approved these changes

Assignees

@ttaerrim ttaerrim

Labels
💄 design 🎨 Front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Layout 컴포넌트 수정
3 participants
@ttaerrim @js43o @LEEJW1953