[Feat] 헤더 상단 고정 및 z-index 수정 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js43o
reviewed
Nov 21, 2023
| @@ -3,10 +3,14 @@ import { style } from '@vanilla-extract/css'; | |||
| import { vars, fontStyle } from '@/styles'; | |||
|
|
|||
| export const container = style({ | |||
| position: 'sticky', | |||
There was a problem hiding this comment.
P3: 'fixed' 대신 'sticky'를 쓰신 이유가 궁금합니다!
There was a problem hiding this comment.
음 생각해보니 fixed를 사용하면 html 높이 속성을 바꿀 필요가 없을 수도 있겠네요 수정하겠습니다!
There was a problem hiding this comment.
넵 지금 minHeight, 100vh 써보는데도 똑같은 현상이 일어나서요..😂 좋습니다!
js43o
approved these changes
Nov 21, 2023
ttaerrim
approved these changes
Nov 21, 2023
| borderBottom: `1px solid ${vars.color.grayscale100}`, | ||
| zIndex: '999', |
There was a problem hiding this comment.
p3; 뭔가 zIndex도 관리하고 싶다는 생각이 드네요.. 찾아보았는데 변수로 관리하는 솔루션도 있네요! (아마 sass?)
LEEJW1953
commented
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
완료한 기능 명세
position : fixed적용z-index : 999적용스크린샷
_2023_11_21_16_42_32_614.mp4
리뷰 요청 사항