Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE/#356] 서버 Redis 연결 #406

Merged
merged 3 commits into from
Dec 9, 2023
Merged

[BE/#356] 서버 Redis 연결 #406

merged 3 commits into from
Dec 9, 2023

Conversation

namewhat99
Copy link
Collaborator

이슈

체크리스트

  • 서버와 Redis 연결

@namewhat99 namewhat99 added review code-review BE BE 관련 environment 공통 개발 환경 설정 labels Dec 9, 2023
@namewhat99 namewhat99 requested a review from koomin1227 December 9, 2023 04:52
@namewhat99 namewhat99 self-assigned this Dec 9, 2023
@namewhat99 namewhat99 changed the title [BE] 서버 Redis 연결 [BE/#356] 서버 Redis 연결 Dec 9, 2023
Comment on lines +32 to +34
CacheModule.registerAsync({
useClass: RedisConfigProvider,
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

캐시 모듈 잘 쓰신 것 같네요

Comment on lines +4 to +13
export class RedisConfigProvider implements CacheOptionsFactory {
configService = new ConfigService();
createCacheOptions(): CacheModuleOptions {
return {
store: redisStore,
host: this.configService.get('REDIS_HOST'),
port: this.configService.get('REDIS_PORT'),
};
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configService에 쓰인 환경변수 사용하는 것이 좋네요

@koomin1227 koomin1227 merged commit f8c2c55 into BE Dec 9, 2023
1 check passed
@namewhat99 namewhat99 deleted the BE-setRedis-#356 branch December 11, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE BE 관련 environment 공통 개발 환경 설정 review code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants