Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

유저 차단 해제 버그 픽스 #613

Merged
merged 2 commits into from
Jan 3, 2024
Merged

유저 차단 해제 버그 픽스 #613

merged 2 commits into from
Jan 3, 2024

Conversation

lsh23
Copy link
Collaborator

@lsh23 lsh23 commented Jan 3, 2024

PR 요약

  • 유저 차단 해제 버그 픽스

변경 사항

  • typeorm이 제공하는 delete 함수 사용시 createdAt javascript Date 형태값이 쿼리문에 포함되어 쿼리가 나가서 특정 row를 식별하지 못하여 삭제가 안되는 이슈를 발견
  • 그에 따라 복합 pk 만을 쿼리문의 조건으로 사용하는 delete 함수 추가

Linked Issue

close #612

@lsh23 lsh23 added BE BE 관련사항 bug 버그 labels Jan 3, 2024
@lsh23 lsh23 self-assigned this Jan 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e51c725) 95.73% compared to head (feb018c) 95.73%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #613   +/-   ##
========================================
  Coverage    95.73%   95.73%           
========================================
  Files          240      240           
  Lines         3515     3517    +2     
  Branches       226      226           
========================================
+ Hits          3365     3367    +2     
  Misses         144      144           
  Partials         6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsh23 lsh23 merged commit a10ac5e into develop Jan 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE BE 관련사항 bug 버그
Projects
None yet
Development

Successfully merging this pull request may close these issues.

유저 차단 해제 버그
2 participants