Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playlist 쿼리문 entity 로 이동 #382

Merged
merged 3 commits into from
Jan 22, 2024
Merged

playlist 쿼리문 entity 로 이동 #382

merged 3 commits into from
Jan 22, 2024

Conversation

khw3754
Copy link
Collaborator

@khw3754 khw3754 commented Jan 22, 2024

Issue

Overview

  • 한 트랜잭션에서 entity 연관관계가 연결되어있는 코드를 제외하고 모두 entity 로 이동

@khw3754
feat : ERROR CODE 추가
d47cedb 
* ENTITY_ERROR 추가
@khw3754
feat : createPlaylist 쿼리문 이동
3d07068 
* entity 층으로 쿼리문 이동
@khw3754
refactor : addMusicToPlaylist 추가
e9d8cb1 
* music_playlist entity 에 addMusicToPlaylist 함수 추가
@khw3754 khw3754 added 🛠️ refactor 리팩토링 🖥 server server labels Jan 22, 2024
@khw3754 khw3754 added this to the ⏯️ playlist milestone Jan 22, 2024
@khw3754 khw3754 self-assigned this Jan 22, 2024
@khw3754 khw3754 requested a review from sk000801 as a code owner January 22, 2024 07:41
@khw3754 khw3754 linked an issue Jan 22, 2024 that may be closed by this pull request
playlist 쿼리문 모두 entity 로 이동 #379
Closed
sk000801
sk000801 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@sk000801 sk000801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 엔티티 에러도 꼼꼼하게 추가해주셨네요! 👍👍

server/src/entity/playlist.entity.ts

@Entity({ name: 'playlist' })
export class Playlist extends BaseEntity {
private static readonly logger: Logger = new Logger('PlaylistEntity');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무언가 이 로그를 보니 repository 계층을 추가하는 패턴이 더 괜찮을 수도 있다는 생각이 드네요..!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동의합니다,,

@khw3754 khw3754 merged commit e3ace90 into develop Jan 22, 2024
1 check passed
@khw3754 khw3754 deleted the server/refactor/379 branch January 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sk000801 sk000801 sk000801 approved these changes

Assignees

@khw3754 khw3754

Labels
🛠️ refactor 리팩토링 🖥 server server
Projects
None yet
Milestone
⏯️ playlist
Development

Successfully merging this pull request may close these issues.

playlist 쿼리문 모두 entity 로 이동
2 participants
@khw3754 @sk000801