Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewModel ExceptionHandling 보일러 플레이트 개선 #369

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

2taezeat
Copy link
Collaborator

@2taezeat 2taezeat commented Jan 9, 2024

@2taezeat 2taezeat changed the title feat: BaseViewModel 추상 클래스 구현 viewModel ExceptionHandling 보일러 플레이트 개선 (진행중) Jan 9, 2024
@2taezeat 2taezeat added 🛠️ refactor 리팩토링 🤖 android android labels Jan 9, 2024
@2taezeat 2taezeat added this to the 🔧 etc milestone Jan 9, 2024
@2taezeat 2taezeat self-assigned this Jan 9, 2024
@2taezeat 2taezeat linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 9, 2024

Test Results

6 tests   6 ✅  1s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 2a95a27.

♻️ This comment has been updated with latest results.

@HamBP HamBP marked this pull request as draft January 24, 2024 14:19
@2taezeat 2taezeat changed the title viewModel ExceptionHandling 보일러 플레이트 개선 (진행중) viewModel ExceptionHandling 보일러 플레이트 개선 Feb 5, 2024
@2taezeat 2taezeat marked this pull request as ready for review February 5, 2024 06:49
…tchy-tape into android/refactor/367

# Conflicts:
#	android/feature/home/src/main/java/com/ohdodok/catchytape/feature/home/HomeViewModel.kt
#	android/feature/upload/src/main/java/com/ohdodok/catchytape/feature/upload/UploadViewModel.kt
Copy link
Member

@HamBP HamBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!

@2taezeat 2taezeat merged commit 7330a5f into develop Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewModel ExceptionHandling 보일러 플레이트 개선
2 participants