Auth, Music, Playlist 에 트랜잭션 추가 #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* queryRunner 활용해 commit, rollback 구현함 * 결과 성공 여부에 관계없이 인스턴스 해제 위해 finally에 release
* /playlist, /playlist/:id API 관련 로직 수정 * queryRunner 활용해 commit, rollback 구현함 * 결과 성공 여부에 관계없이 인스턴스 해제 위해 finally에 release
* DataSource를 생성자에 추가 * 삽입, 삭제 로직은 커밋/롤백 * select에는 쿼리 빌더 활용
* DataSource가 추가됨에 따라, 이에 맞는 의존성 추가 * 다만 mock 시키고 임의로 로직을 수정하여 통과시킨 테스트라 추후 수정해야함
* DataSource가 추가됨에 따라, 이에 맞는 의존성 추가
Closed
khw3754
approved these changes
Jan 9, 2024
* queryBuilder를 사용하는 이유가 일관성 하나밖에 없어, 일단은 원래대로 두고 추후 개선 예정.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Screenshot
To Reviewers
어딘가 코드가 규칙성 없어보이면 말해주세요! 그리고 위의 overview에 이어서 트랜잭션 코드 추가하심 될 것 같아요
그리고 auth는 idToken이 있어야 잘 들어가는지 확인이 가능해서 이따 코어 시간에 한번 해봐야할 것 같아요!