구글 로그인 - google token 가져오기 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youlalala
force-pushed
the
android/feature/login
branch
from
91101a8 to
ec77cb4
Compare
|
코멘트 외에 이상없습니다~ 고생하셨습니다~ |
2taezeat
approved these changes
Nov 16, 2023
android/feature/login/src/main/java/com/ohdodok/catchytape/feature/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
android/feature/login/src/main/java/com/ohdodok/catchytape/feature/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
2taezeat
approved these changes
Nov 16, 2023
android/feature/login/src/main/java/com/ohdodok/catchytape/feature/login/LoginFragment.kt
Outdated
Show resolved
Hide resolved
HamBP
reviewed
Nov 16, 2023
android/feature/login/src/main/java/com/ohdodok/catchytape/feature/login/LoginViewModel.kt
Outdated
Show resolved
Hide resolved
youlalala
force-pushed
the
android/feature/login
branch
from
35a9f45 to
31a4eab
Compare
youlalala
force-pushed
the
android/feature/login
branch
2 times, most recently
from
56b2dce to
fa27329
Compare
youlalala
force-pushed
the
android/feature/login
branch
from
a838af4 to
11f7c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Screenshot
To Reviewers
서버를 기다리는 중이라 google token 받아오는 코드만 우선 pr 올립니다~
google server client id 는 따로 드릴게여