음원 파일 업로드 (유저 입력) #103
Merged
음원 파일 업로드 (유저 입력) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
youlalala
reviewed
Nov 16, 2023
android/core/ui/src/main/java/com/ohdodok/catchytape/core/ui/BindingAdapter.kt
Outdated
Show resolved
Hide resolved
HamBP
requested changes
Nov 16, 2023
android/core/ui/src/main/java/com/ohdodok/catchytape/core/ui/BindingAdapter.kt
Outdated
Show resolved
Hide resolved
Comment on lines
2
to
7
| <resources> | ||
| <string-array name="genre_items"> | ||
| <item>장르를 선택해 주세요.</item> | ||
| <item>genre1</item> | ||
| <item>genre2</item> | ||
| <item>genre3</item> |
There was a problem hiding this comment.
장르는 서버에서 내려주기로해서 이 배열은 없어도 될 거 같아
There was a problem hiding this comment.
서버 api 가 아직 없는 상황에서, 아무것도 선택안한 경우, 버튼 비활성화를 고려해서 넣었습니다~
There was a problem hiding this comment.
서버 api가 없는 경우면 viewModel 에서 임시로 dummy 리스트를 들고있게 구현하면 나중에 더 수정하기 쉬워져
android/feature/upload/src/main/java/com/ohdodok/catchytape/feature/upload/UploadViewModel.kt
Outdated
Show resolved
Hide resolved
android/core/ui/src/main/java/com/ohdodok/catchytape/core/ui/BindingAdapter.kt
Outdated
Show resolved
Hide resolved
android/core/ui/src/main/java/com/ohdodok/catchytape/core/ui/BindingAdapter.kt
Outdated
Show resolved
Hide resolved
HamBP
reviewed
Nov 16, 2023
youlalala
reviewed
Nov 16, 2023
youlalala
reviewed
Nov 16, 2023
android/core/ui/src/main/java/com/ohdodok/catchytape/core/ui/BindingAdapter.kt
Outdated
Show resolved
Hide resolved
Merged
HamBP
reviewed
Nov 16, 2023
Comment on lines
+28
to
+39
| private fun observeMusicTitle() { | ||
| uploadedMusicTitle.onEach { | ||
| _isUploadEnable.value = uploadedMusicGenrePosition.value != 0 && it.isNotEmpty() | ||
| }.launchIn(viewModelScope) | ||
| } | ||
|
|
||
|
|
||
| private fun observeGenrePosition() { | ||
| uploadedMusicGenrePosition.onEach { | ||
| _isUploadEnable.value = it != 0 && uploadedMusicTitle.value.isNotEmpty() | ||
| }.launchIn(viewModelScope) | ||
| } |
There was a problem hiding this comment.
이 부분은 flow의 combine을 이용해서 해결하는 게 더 깔끔할 거 같아
There was a problem hiding this comment.
혹시 0번 포지션은 "선택 없음"이 아니라 "디폴트"값이 아닐까?
There was a problem hiding this comment.
선택하지 않은 경우를 0으로 가정하였습니다~
HamBP
reviewed
Nov 16, 2023
There was a problem hiding this comment.
업로드화면에서 사용할 거라면 업로드 모듈에서 해도 되지 않을까?
There was a problem hiding this comment.
다른 화면에서도 사용가능성 고려 및
애써서, core-ui 로 모듈을 나누어 놨으니, ui 관련은 모아두는 게 적합하다고 생각했어요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
Screenshot