typeorm 세팅 #47
Merged
typeorm 세팅 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhji
approved these changes
Nov 13, 2024
| @CreateDateColumn({ name: 'created_at' }) | ||
| createdAt: Date; | ||
|
|
||
| @ManyToMany(() => Lotus, (lotus) => lotus.category) |
There was a problem hiding this comment.
다 대 다 관계에 대해서 해당 방식을 사용하면 하이버네이트가 알아서 중간 테이블을 만들어주지만, 실무에선 지양해야한다는 내용을 본 적이 있습니다. 다만 저희는 태그와 lotus 사이의 관계에 추가적으로 필요한 column이 없기 때문에 이렇게 써도 좋은 것 같아요!
There was a problem hiding this comment.
좋은 정보 감사합니다. 추후에 중간 테이블에 접근할때 쿼리문을 예측할 수 없으니 추후에 관리할 수 있는 entity로 만들어서 최적화를 하는 것도 좋은 고려사항일 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#42
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
현재 module에서 service,repository를 export하여 각 모듈을 import하는 방식으로 했는데 확신이 서지는 않는 것 같네요. 모듈을 분리한다는 관점에서는 이 방식이 맞지 않을까? 라는 생각으로 의존성 주입을 추가했습니다.