-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#269 workspace 관련 완성도 개선 #273
Merged
The head ref may contain hidden characters: "Feature/#269_workspace_\uAD00\uB828_\uC644\uC131\uB3C4_\uAC1C\uC120"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UI적 느낌이 떨어지는 것 같아 추후 필요하다면 수정해서 사용 - useWorkspaceStore에서 이름, 접속자수, 권한 등을 저장 #269
minjungw00
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고많으셨습니다!
Ludovico7
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 변경 사항
워크스페이스 join, leave에 따라 워크스페이스 유저에게 토글창 표시
66616115.mp4
워크스페이스 이름변경 추가
142.mp4
온보딩 오버레이 바로끄는 close 아이콘 추가
🔍 변경 사항 설명
workspace/user/join
,workspace/user/leave
로 판단합니다.workspace/rename
을 수신하고workspace/list
를 보내서 갱신합니다.🙏 질문 사항
📷 스크린샷 (선택)
✅ 작성자 체크리스트