Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#139 react query 세팅 #146

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Feature/#139 react query 세팅 #146

merged 5 commits into from
Nov 18, 2024

Conversation

pipisebastian
Copy link
Member

@pipisebastian pipisebastian commented Nov 18, 2024 •
edited
Loading

📝 변경 사항

🔍 변경 사항 설명

  • 로그인했을때 토큰관리는 아직 안했습니다

🙏 질문 사항

  • 리뷰어에게 부탁하고싶은 체크리스트를 추가합니다.

📷 스크린샷 (선택)

  • UI 변경이 있는 경우 스크린샷이나 GIF를 첨부합니다.

✅ 작성자 체크리스트

  • Self-review: 코드가 스스로 검토됨
  • Unit tests 추가 또는 수정
  • 로컬에서 모든 기능이 정상 작동함
  • 린터 및 포맷터로 코드 정리됨
  • 의존성 업데이트 확인
  • 문서 업데이트 또는 주석 추가 (필요 시)

@pipisebastian pipisebastian self-assigned this Nov 18, 2024
@pipisebastian pipisebastian added FE 프론트엔드 작업 Feat 새로운 기능 추가나 기존 기능 확장 작업 labels Nov 18, 2024
minjungw00 and others added 2 commits November 18, 2024 17:20
@minjungw00
fix: API 서버 URL, CORS 권한 수정
86c80b7 
#139
@hyonun321
fix: crdt.linkedlist.nodeMap 의 빈객체를 mongoDB에 저장하지 못하는 문제
eba87c2 
- 이에따라 nodeMap에 || null 추가
- mongoDB에 minimize 설정 추가
- 필요없어진 JSON stringify 제거
minjungw00
minjungw00 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@minjungw00 minjungw00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!

hyonun321
hyonun321 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@hyonun321 hyonun321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조금 짬뽕이 된 감이 있는데.. 일단 approve하겠습니다. 다음번엔 이런 commit은 hotfix branch를 만드는게 좋겠네요.

@github-actions github-actions bot merged commit b83df84 into dev Nov 18, 2024
5 checks passed
Ludovico7
Ludovico7 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Ludovico7 Ludovico7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@pipisebastian pipisebastian deleted the Feature/#139_react_query_세팅 branch November 26, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyonun321 hyonun321 hyonun321 approved these changes

@Ludovico7 Ludovico7 Ludovico7 approved these changes

@minjungw00 minjungw00 minjungw00 approved these changes

Assignees

@pipisebastian pipisebastian

Labels
FE 프론트엔드 작업 Feat 새로운 기능 추가나 기존 기능 확장 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react query 세팅
4 participants
@pipisebastian @minjungw00 @Ludovico7 @hyonun321