Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#130 로그인 회원가입 ui 구현 #135

Merged
merged 12 commits into from
Nov 18, 2024
Merged

Feature/#130 로그인 회원가입 ui 구현 #135

merged 12 commits into from
Nov 18, 2024

Conversation

pipisebastian
Copy link
Member

@pipisebastian pipisebastian commented Nov 17, 2024 •
edited
Loading

📝 변경 사항

🔍 변경 사항 설명

  • 선행 리뷰 부탁드립니다! (반영중입니다..)
  • 유효성 검사는 개발단계에서는 따로 추가안했습니다! 나중에 배포전에 하겠습니다.

🙏 질문 사항

  • 리뷰어에게 부탁하고싶은 체크리스트를 추가합니다.

📷 스크린샷 (선택)

2024-11-17.7.33.01.mov

✅ 작성자 체크리스트

  • Self-review: 코드가 스스로 검토됨
  • Unit tests 추가 또는 수정
  • 로컬에서 모든 기능이 정상 작동함
  • 린터 및 포맷터로 코드 정리됨
  • 의존성 업데이트 확인
  • 문서 업데이트 또는 주석 추가 (필요 시)

@pipisebastian pipisebastian added FE 프론트엔드 작업 Feat 새로운 기능 추가나 기존 기능 확장 작업 labels Nov 17, 2024
@pipisebastian pipisebastian self-assigned this Nov 17, 2024
@pipisebastian pipisebastian changed the title Feature/#130 로그인 회원가입 u 구현 Feature/#130 로그인 회원가입 ui 구현 Nov 17, 2024
minjungw00
minjungw00 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@minjungw00 minjungw00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달창 디자인 이쁘네요! 수고많으셨습니다!

hyonun321
hyonun321 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@hyonun321 hyonun321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!

Ludovico7
Ludovico7 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@Ludovico7 Ludovico7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot merged commit 07c63f7 into dev Nov 18, 2024
5 checks passed
@pipisebastian pipisebastian deleted the Feature/#130_로그인_회원가입_U_구현 branch November 26, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyonun321 hyonun321 hyonun321 approved these changes

@Ludovico7 Ludovico7 Ludovico7 approved these changes

@minjungw00 minjungw00 minjungw00 approved these changes

Assignees

@pipisebastian pipisebastian

Labels
FE 프론트엔드 작업 Feat 새로운 기능 추가나 기존 기능 확장 작업
Projects
None yet
Milestone
사용자는 계정을 관리할 수 있다.
Development

Successfully merging this pull request may close these issues.

로그인 회원가입 UI 구현
4 participants
@pipisebastian @minjungw00 @Ludovico7 @hyonun321