-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#127 탭 브라우징 피드백 반영 #129
The head ref may contain hidden characters: "Feature/#127_\uD0ED_\uBE0C\uB77C\uC6B0\uC9D5_\uD53C\uB4DC\uBC31_\uBC18\uC601"
Changes from all commits
473da03
aca483a
e30425d
e566a00
b0a7fff
308115e
14a7f98
3d4ac43
052bebb
aafc551
a458d52
384e959
beb608d
9b437c5
1778ada
22299ac
1c33455
7d62760
7d3fd54
1f153ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export const MAX_VISIBLE_PAGE = 10; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
export const pageAnimation = { | ||
initial: { | ||
x: -300, | ||
x: 0, | ||
y: 0, | ||
opacity: 0, | ||
scale: 0.8, | ||
|
@@ -12,7 +12,9 @@ export const pageAnimation = { | |
scale: 1, | ||
boxShadow: isActive ? "0 8px 30px rgba(0,0,0,0.15)" : "0 2px 10px rgba(0,0,0,0.1)", | ||
transition: { | ||
boxShadow: { duration: 0.2 }, | ||
x: { type: "tween", duration: 0.03, ease: "linear" }, | ||
y: { type: "tween", duration: 0.03, ease: "linear" }, | ||
scale: { type: "spring", stiffness: 300, damping: 15 }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 묵직하게 움직이는 애니메이션이 빠르게 바뀌었군요. 지금이 UX적으로 반응이더 좋은 듯 하네요! |
||
}, | ||
}), | ||
}; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
import { pageControlContainer, pageControlButton } from "./PageControlButton.style"; | ||
import CloseIcon from "@assets/icons/close.svg?react"; | ||
import ExpandIcon from "@assets/icons/expand.svg?react"; | ||
import MinusIcon from "@assets/icons/minus.svg?react"; | ||
import { pageControlContainer, pageControlButton, iconBox } from "./PageControlButton.style"; | ||
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. svg 이미지를 컴포넌트로 사용하는 방식이네요! |
||
|
||
interface PageControlButtonProps { | ||
onPageMinimize?: () => void; | ||
|
@@ -13,11 +16,15 @@ export const PageControlButton = ({ | |
}: PageControlButtonProps) => { | ||
return ( | ||
<div className={pageControlContainer}> | ||
<button className={pageControlButton({ color: "yellow" })} onClick={onPageMinimize} /> | ||
|
||
<button className={pageControlButton({ color: "red" })} onClick={onPageClose} /> | ||
|
||
<button className={pageControlButton({ color: "green" })} onClick={onPageMaximize} /> | ||
<button className={pageControlButton({ color: "yellow" })} onClick={onPageMinimize}> | ||
<MinusIcon className={iconBox} /> | ||
</button> | ||
<button className={pageControlButton({ color: "green" })} onClick={onPageMaximize}> | ||
<ExpandIcon className={iconBox} /> | ||
</button> | ||
<button className={pageControlButton({ color: "red" })} onClick={onPageClose}> | ||
<CloseIcon className={iconBox} /> | ||
</button> | ||
</div> | ||
); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,7 @@ import { css } from "@styled-system/css"; | |
export const pageTitle = css({ | ||
textStyle: "display-medium24", | ||
color: "gray.500", | ||
textOverflow: "ellipsis", | ||
overflow: "hidden", | ||
whiteSpace: "nowrap", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 글자들이 밖으로 나가는 부분이 없어졌군요! 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저,, 저건,, 일단 몰루,, 하겠습니다... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. webkit을 통해 우측 스크롤바 디자인을 변경해봐도 좋을것 같습니다! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 스크롤바 디자인 간단하게 수정해봤습니다! 2024-11-17.8.03.02.movThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이게 훨씬 깔끔하네요! 너무좋습니다 !! |
||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
page가 잠깐 생길때 x축에도 스크롤이 발생하네요.
x축 스크롤은 안보이는게 처리하는게 좋을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 좋은 것 같습니다!! 수정하겠습니다!