Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#107 클라이언트 빌드 에러 해결 #108

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Feature/#107 클라이언트 빌드 에러 해결 #108

merged 2 commits into from
Nov 13, 2024

Conversation

pipisebastian
Copy link
Member

📝 변경 사항

  • 클라이언트 빌드 에러 해결

🔍 변경 사항 설명

  • 안쓰는 useState 제거
  • Editor 타입 명시 추가

🙏 질문 사항

  • 리뷰어에게 부탁하고싶은 체크리스트를 추가합니다.

📷 스크린샷 (선택)

  • UI 변경이 있는 경우 스크린샷이나 GIF를 첨부합니다.

✅ 작성자 체크리스트

  • Self-review: 코드가 스스로 검토됨
  • Unit tests 추가 또는 수정
  • 로컬에서 모든 기능이 정상 작동함
  • 린터 및 포맷터로 코드 정리됨
  • 의존성 업데이트 확인
  • 문서 업데이트 또는 주석 추가 (필요 시)

@pipisebastian pipisebastian self-assigned this Nov 13, 2024
@pipisebastian pipisebastian added Bug 기능 또는 UI에서 발생한 오류나 예상치 못한 동작을 해결 FE 프론트엔드 작업 labels Nov 13, 2024
@pipisebastian Slack
Copy link
Member Author

짜잔

minjungw00
minjungw00 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@minjungw00 minjungw00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hyonun321
hyonun321 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@hyonun321 hyonun321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Ludovico7
Ludovico7 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@Ludovico7 Ludovico7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot merged commit 7ffba4b into dev Nov 13, 2024
3 checks passed
@pipisebastian pipisebastian deleted the Feature/#107_클라이언트_빌드_에러_해결 branch November 15, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyonun321 hyonun321 hyonun321 approved these changes

@Ludovico7 Ludovico7 Ludovico7 approved these changes

@minjungw00 minjungw00 minjungw00 approved these changes

Assignees

@pipisebastian pipisebastian

Labels
Bug 기능 또는 UI에서 발생한 오류나 예상치 못한 동작을 해결 FE 프론트엔드 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pipisebastian @minjungw00 @Ludovico7 @hyonun321