-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
노드 생성 드래그 관련 버그 개선 #169
Merged
Merged
노드 생성 드래그 관련 버그 개선 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatyJazzy
requested review from
hoqn and
heegenie
and removed request for
a team
November 28, 2024 11:06
alert으로 추가하셨군요..! 제가 앞선 PR에서 지원되지 않는 메뉴는 없애놨었는데 다시 복구해도 좋아요! alert으로 하는 게 더 나을 것 같아요 |
저 오른쪽 클릭이 아예 안 되고, 일반 클릭으로 먹어요..! (맥북, 노드 엣지 모두) |
hoqn
approved these changes
Nov 28, 2024
일단 우클릭은 다시 작동하도록 복귀했고 이벤트 핸들러 넘겨주는 것을 stage > node, edge로 변경했어요. 윈도우 테스트까지 해봐야 ... 목표 달성일 것 같습니다. alert는 그대로 살렸습니다. 이번 PR 정말 감사했습니다ㅠㅠ (@hoqn ✨) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 한 줄 설명
드래그 상태를 변경 관련한 성능 개선, 드롭 후 팔레트 메뉴 표시되었을 때 숨김처리하는 로직을 개선했어요.
✅ 작업 내용
🏷️ 관련 이슈
📸 스크린샷/영상
📌 리뷰 진행 시 참고 사항