Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#378 - 쿼리 캐싱, 무효화 설정 및 자잘한 에러 수정, 스켈레톤 추가 #380

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Feature/#378 - 쿼리 캐싱, 무효화 설정 및 자잘한 에러 수정, 스켈레톤 추가 #380

merged 8 commits into from
Dec 5, 2024

Conversation

baegyeong
Copy link
Collaborator

@baegyeong baegyeong commented Dec 5, 2024 •
edited
Loading

close #376

✅ 작업 내용

  • 테스트 로그인 시 로그인 상태가 업데이트 되지 않는 문제 수정
  • 캐싱을 위한 staleTime 지정
  • 그래프 시간 데이터 staleTime 줄임
  • 가격 등락률 순 정렬 시 깜빡이는 문제 -> placeholderData 옵션 지정
  • 다크모드가 새로고침 하면 풀리는 문제 -> 서버에서 사용자의 상태를 받을 때 undefined인 상태에서 테마를 적용하려 해서 발생하는 문제였음
  • 라이브 데이터 받기전에 초기값인 0이 보이는 경우가 있어 skeleton을 적용
    skeleton

😎 체크 사항

  • label 설정 확인
  • 브랜치 방향 확인

@baegyeong baegyeong added 🐞 bugfix Something isn't working FE labels Dec 5, 2024
@baegyeong baegyeong requested a review from a team December 5, 2024 05:23
@baegyeong baegyeong self-assigned this Dec 5, 2024
@baegyeong baegyeong changed the title Feature/#378 - 쿼리 캐싱, 무효화 설정 및 자잘한 에러 수정 Feature/#378 - 쿼리 캐싱, 무효화 설정 및 자잘한 에러 수정, 스켈레톤 추가 Dec 5, 2024
swkim12345
swkim12345 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@swkim12345 swkim12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

xjfcnfw3
xjfcnfw3 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@xjfcnfw3 xjfcnfw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@baegyeong baegyeong merged commit fe8c52e into dev-fe Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjfcnfw3 xjfcnfw3 xjfcnfw3 approved these changes

@swkim12345 swkim12345 swkim12345 approved these changes

Assignees

@baegyeong baegyeong

Labels
FE 🐞 bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baegyeong @swkim12345 @xjfcnfw3