Bug/#202 - 웹 소켓 비어있는 쿠키 에러 수정 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swkim12345
reviewed
Nov 20, 2024
| const cookieValue = websocketCookieParse(socket); | ||
| const session = await this.getSession(cookieValue); | ||
| return session ? session.passport.user : null; | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
webStom에서 발생한 경고에서 주석을 사용하라는 액션을 통해서 작성했습니다.
왠만하면 작성안하려고 했는데 에러가 발생했을 때 잡은 에러를 사용할 일이 없어서 일단 이렇게 했습니다.
swkim12345
reviewed
Nov 20, 2024
| } | ||
|
|
||
| private getSession(cookieValue: string) { | ||
| return new Promise<PassportSession | undefined>((resolve) => { | ||
| return new Promise<PassportSession | null>((resolve) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #202
✅ 작업 내용
😎 체크 사항