[BE] 회원가입 API 구현 #29
Merged
[BE] 회원가입 API 구현 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-JuGa into feat/api/register-#26
uuuo3o
reviewed
Nov 6, 2024
| @@ -1,6 +1,6 @@ | |||
| import { Controller, Get, Body } from '@nestjs/common'; | |||
| import { AuthService } from './auth.service'; | |||
| import { AuthCredentialsDto } from './dto/auth-credential-dto'; | |||
| import { AuthCredentialsDto } from './dto/authCredentials.dto'; | |||
There was a problem hiding this comment.
🟢 이런 네이밍 규칙도 나중에 이야기해보면 좋겠네요!
저는 케밥 케이스 방식을 써서
auth-credential.dto 이런 식으로 작성하고 있었거든요!
There was a problem hiding this comment.
이런 네이밍 규칙도 나중에 이야기해보면 좋겠네요! 저는 케밥 케이스 방식을 써서
auth-credential.dto이런 식으로 작성하고 있었거든요!
어라? 저도 진님이 하신게 기억나서 고쳐논건데 왜 다시 되돌아 왔는지 모르겠네요 ㅎㅎ
한번 이야기 해보면 좋을거 같아요!
sieunie
reviewed
Nov 6, 2024
| @@ -14,9 +16,10 @@ import { AppService } from './app.service'; | |||
| username: process.env.DB_USERNAME, | |||
| password: process.env.DB_PASSWD, | |||
| database: process.env.DB_DATABASE, | |||
| entities: [], | |||
| entities: [User], | |||
There was a problem hiding this comment.
🟢 auth.module에서 user 엔티티로 등록되어있는 것 같은데, 혹시 여기서 한번 더 등록해주어야 할 필요가 있는 건가용...?
There was a problem hiding this comment.
해당 부분에서 등록하는 부분과 auth.module에서 등록하는 부분이 다른 걸로 알고 있습니다.
TypeOrmModule의 옵션인 entities에 포함 해주면 엔티티에 맞춰서 자동으로 데이터 테이블을 생성해 준다고 알고 있습니다!
Closed
sieunie
approved these changes
Nov 6, 2024
uuuo3o
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 주요 작업
💭 고민과 해결과정
NestJs를 이용한 코딩 경험이 없다 보니 문법이나 여러 기능들에 대해 많이 생소해 공부와 병행하면서 코드 작성을 진행하였습니다.
NestJS 개념 정리
https://j-i-n.notion.site/nest-js-1351aba2272881c5ba01e3d4b40434ee
참고한 강의
https://www.inflearn.com/course/%EB%94%B0%EB%9D%BC%ED%95%98%EB%8A%94-%EB%84%A4%EC%8A%A4%ED%8A%B8-%EC%A0%9C%EC%9D%B4%EC%97%90%EC%8A%A4