Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix/audio] 오디오 중단 & 재시작 할때의 음성 표시 바 수정 #148

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

yuncheol-AHN
Copy link
Collaborator

@yuncheol-AHN yuncheol-AHN commented Dec 5, 2024

#️⃣ 연관된 이슈


⏰ 작업 시간

예상 시간 실제 걸린 시간
1 1

📝 작업 내용

  • 오디오 컨트롤러에서 중단 버튼 터치할 때, 오디오 음파 정지
  • 중단 시 녹음 버튼 "arrow.clockwise"로 수정

📸 스크린샷

ScreenRecording_12-05-2024.11-53-35_1.MP4

@yuncheol-AHN yuncheol-AHN self-assigned this Dec 5, 2024
@yuncheol-AHN yuncheol-AHN added the 🛠️ Fix 오류, 버그 수정 label Dec 5, 2024
@yuncheol-AHN yuncheol-AHN added this to the 0.5 milestone Dec 5, 2024
Copy link
Collaborator

@iceHood iceHood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죠습니다! 고생하셨어요!

Copy link
Collaborator

@Kyxxn Kyxxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!!
궁금한 점 아래에 달아두었습니다

Comment on lines -28 to +29
AVNumberOfChannelsKey: 2,
AVEncoderAudioQualityKey: AVAudioQuality.high.rawValue
AVNumberOfChannelsKey: 1,
AVEncoderAudioQualityKey: AVAudioQuality.medium.rawValue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 AVNumberOfChannelsKey랑 AVEncoderAudioQualityKey는 몬가요..?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AVNumberOfChannelsKey: 음성 채널 수(Int)
AVEncoderAudioQualityKey: 오디오 품질(Enum)
입니다. 아래의 링크 참고해서 AVSampleRateKey 값과 AVEncoderAudioQualityKey 값을 맞췄습니다.

https://hoseiocean.medium.com/an-ios-developer-dive-in-avfaudio-choosing-the-sampling-rate-ea72217f4b45

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에 음성 채널 수가 2였는데 지금 1로 바뀐 이유는 뭔가요 ?!
그리고 품질이라면 high에서 Medium으로 낮추신 이유도 궁금합니다

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래의 사진을 참조하면

Rate 별 타입을 확인할 수 있는데, 현재 Rate 값인 44100에 medium이 어울린다고 판단해 수정했습니다. 그리고, 음성 채널 수는 단순한 녹음 기능이기에 1개만 있으면 충분하다 생각했습니다. 기존의 2개는 world wide web의 떠도는 코드를 가져와서 그렇습니다 ㅎ ㅠ.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 감사합니다 !!

Copy link
Collaborator

@k2645 k2645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니당 ~.ᐟ.ᐟ 👍

@yuncheol-AHN yuncheol-AHN changed the title Hotfix/audio [Hotfix/audio] 오디오 중단 & 재시작 할때의 음성 표시 바 수정 Dec 5, 2024
@yuncheol-AHN yuncheol-AHN merged commit bc05e2f into develop Dec 5, 2024
2 checks passed
@yuncheol-AHN yuncheol-AHN deleted the hotfix/audio branch December 5, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Fix 오류, 버그 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants