Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phaser refactoring #169

Merged
merged 6 commits into from
Dec 8, 2022
Merged

phaser refactoring #169

merged 6 commits into from
Dec 8, 2022

Conversation

ktmihs
Copy link
Member

@ktmihs ktmihs commented Dec 8, 2022

๐Ÿ“• ์ œ๋ชฉ

๐Ÿ“— ์ž‘์—… ๋‚ด์šฉ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • ๊ฒŒ์ž„ ๋งต ๋ฐ”์šด๋”๋ฆฌ ์„ค์ •
  • ํ•œ๊ธ€ ๊นจ์ง ๋ฒ„๊ทธ ์ˆ˜์ •
  • ์นœ๊ตฌ ๋ชฉ๋ก ์ „์—ญ ์ƒํƒœ ๋ณ€๊ฒฝ

๐Ÿ“˜ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

ktmihs added 6 commits December 8, 2022 22:34
@ktmihs
[feat] boostcampwm-2022#137 ๊ฒŒ์ž„ ๋งต ๋ฐ”์šด๋”๋ฆฌ ์„ค์ •
de1bc08 
- ์นด๋ฉ”๋ผ๊ฐ€ ๋งต ์™ธ๋ถ€๋กœ ๋ฒ—์–ด๋‚˜์ง€ ๋ชปํ•˜๋„๋ก ์„ค์ •
@ktmihs
[fix] boostcampwm-2022#160 ํ•œ๊ธ€ ๊นจ์ง ๋ฒ„๊ทธ ์ˆ˜์ •
5c6dbde 
- ์„ค์น˜ํ•œ ํฐํŠธ์— ์—†๋Š” ๊ธ€์ž๊ฐ€ ๊นจ์ ธ๋ณด์ด๋Š” ๊ฒƒ์œผ๋กœ ํ™•์ธ
- font-family๋กœ ๋Œ€์ฒด ํฐํŠธ ์„ค์ •
@ktmihs
[fix] boostcampwm-2022#160 ํ•œ๊ธ€ ๊นจ์ง ๋ฒ„๊ทธ ์ˆ˜์ •
3fd8c67 
- ์„ค์น˜ํ•œ ํฐํŠธ์— ์—†๋Š” ๊ธ€์ž๊ฐ€ ๊นจ์ ธ๋ณด์ด๋Š” ๊ฒƒ์œผ๋กœ ํ™•์ธ
- font-family๋กœ ๋Œ€์ฒด ํฐํŠธ ์„ค์ •
@ktmihs
[refactor] boostcampwm-2022#66 boostcampwm-2022#85 ๋‹‰๋„ค์ž„ ๋ฐ”๊พผ ์นœ๊ตฌ ์กด์žฌ ์‹œ, ์ „์—ญโ€ฆ
c684751 
โ€ฆ ๋ณ€์ˆ˜์— ๋ฐ˜์˜ํ•ด์ฃผ๊ธฐ

- ์ „์—ญ key๋ฅผ nickname์—์„œ id๋กœ ๋ณ€๊ฒฝ
- ํ•ด๋‹น๋˜๋Š” id๋ฅผ ์ฐพ์•„ nickname ๋ณ€๊ฒฝํ•ด์ฃผ๊ธฐ
@ktmihs
[refactor] boostcampwm-2022#66 ์นœ๊ตฌ ์ƒํƒœ์— busy๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ํ™œ์„ฑ ์ƒํƒœ ์ƒ‰์ƒ ํ‘œ์‹œ
27e8a5f 
- busy์ผ ๋•Œ๋Š” ๋…ธ๋ž€์ƒ‰์œผ๋กœ ํ‘œ์‹œ
@ktmihs
[fix] boostcampwm-2022#85 ์ „์—ญ์ƒํƒœ ์ˆ˜์ • ์‹œ, ๋ฏธ๋ฐ˜์˜๋œ ๋ถ€๋ถ„ ๋ณ€๊ฒฝ
fd6c3e6 
- username -> id๋กœ ๋ณ€๊ฒฝํ•˜๋Š” ๊ณผ์ •์—์„œ ๋ฏธ๋ฐ˜์˜๋œ ๋ถ€๋ถ„๋“ค ๋ฐ˜์˜
@ktmihs ktmihs self-assigned this Dec 8, 2022
@JJongBin
Copy link
Collaborator

JJongBin commented Dec 8, 2022

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹น!

@JJongBin JJongBin merged commit 8e7c0ba into boostcampwm-2022:develop Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ktmihs ktmihs

Labels
๋ฆฌํŒฉํ† ๋ง Refactoring ๋ฒ„๊ทธ ํ”„๋ก ํŠธ์—”๋“œ ํ”„๋ก ํŠธ์—”๋“œ
Projects
SleepyWoods
Status: ๐ŸŽ„ โœ”Done
Milestone
[ 4์ฃผ์ฐจ ] 22.12.05 ~ 22.12.11
Development

Successfully merging this pull request may close these issues.
2 participants
@ktmihs @JJongBin