이미지 처리 및 캐싱 모듈 수정 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongpower
reviewed
Dec 12, 2022
| // Created by 장재훈 on 2022/12/10. | ||
| // | ||
|
|
||
| import UIKit.UIImage |
| private let cache = NSCache<NSString, NSData>() | ||
| private let cache: NSCache = { | ||
| let cache = NSCache<NSString, NSData>() | ||
| cache.totalCostLimit = 52428800 |
There was a problem hiding this comment.
혹시 이 totalCostLimit 은 어떻게 계산해서(?) 나온 값인가요?
There was a problem hiding this comment.
50MB 인데요
저희 Storage 에 4명이서 마구마구 올려둔 이미지 용량이 총 80MB 이더라구요
그리고 앱 메모리를 얼마나 쓰냐 생각해봤을때 캐시가 100MB 라고 하면 넘 많은것 같아서 50MB 정도가 적당하겠다 싶었읍니다
|
리뷰 감사합니당 ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제출 전 필수 확인 사항:
작업 내용: