Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

자잘한 버그 수정 및 리팩토링 #93

Merged
merged 4 commits into from
Dec 8, 2022
Merged

자잘한 버그 수정 및 리팩토링 #93

merged 4 commits into from
Dec 8, 2022

Conversation

hongpower
Copy link
Collaborator

제출 전 필수 확인 사항:

  • Merge 하는 브랜치가 올바른가?
  • 코드 컨벤션을 준수하는가?
  • 빌드가 되는 코드인가요?
  • 버그가 발생하지 않는지 충분히 테스트 해봤나요?

작업 내용:

  • 앱 아이콘 하나로 변경
  • 커스텀 블러뷰 생성 및 블러 수정
  • NavigationBar 뒤로 버튼 모든 뷰에 통일

이번에 공들였던 부분:

단순 구현이라 없음

@hongpower hongpower added bug Something isn't working review refactor labels Dec 8, 2022
@hongpower hongpower requested a review from solbat December 8, 2022 11:35
@hongpower hongpower self-assigned this Dec 8, 2022
solbat
solbat approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@solbat solbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘하셨습니다. 특히 수정 시에 한 부분만 고치지 않고 모든 부분을 같이 고친 점이 좋네요. 섬세한 코드 박수!

@solbat solbat merged commit 4b3728a into develop Dec 8, 2022
@trumanfromkorea trumanfromkorea deleted the fix_total branch December 12, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solbat solbat solbat approved these changes

Assignees

@hongpower hongpower

Labels
bug Something isn't working refactor review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongpower @solbat