[프로필] 회원 탈퇴 오류 수정 및 Storage 사진 삭제 구현 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
62
to
66
| if let error = error { | ||
| completion(FBStorageError.failedDeleteData) | ||
| return | ||
| } | ||
| completion(nil) |
There was a problem hiding this comment.
return 이 필수라면 guard let 도 방법이겠군요
There was a problem hiding this comment.
그리고 swift 5.7 부터 guard let 이나 if let 구문 사용 시 바인딩하려는 변수 이름이 같다면
if let error {
print(error)
}
guard let error else {
return
}
print(error)
요렇게 간단하게 사용할 수 있더라구요
이미 알고 계실것 같지만 덧붙여서 말씀드려봅니당 (_ _)
| @@ -9,6 +9,8 @@ import SnapKit | |||
| import UIKit | |||
|
|
|||
| final class ProfileView: UIView, BaseView { | |||
| let loadingIndicator = LoadingIndicatorView() | |||
Comment on lines
+143
to
+148
| func applyLoadingIndicator() { | ||
| addSubview(loadingIndicator) | ||
| loadingIndicator.snp.makeConstraints { | ||
| $0.center.equalToSuperview() | ||
| } | ||
| } |
There was a problem hiding this comment.
사실 CustomNavigationController 클래스에 addIndicatorView, removeIndicatorView 메소드가 구현되어있습니다.
LoadingIndicatorView 를 VC 가 가지고있는 View 에 추가하게 되면 navigationBar 는 덮히지 않는 현상이 발생해서 navigationController 에 넣어두었습니다. 이 점을 활용해도 좋을 것 같아요
더 좋은 의견이 있으면 말씀해주세요 💙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제출 전 필수 확인 사항:
작업 내용:
이번에 공들였던 부분: