Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[홈] 버그 수정 #109

Merged
merged 3 commits into from
Dec 12, 2022
Merged

[홈] 버그 수정 #109

merged 3 commits into from
Dec 12, 2022

Conversation

solbat
Copy link
Member

@solbat solbat commented Dec 12, 2022

제출 전 필수 확인 사항:

  • Merge 하는 브랜치가 올바른가?
  • 코드 컨벤션을 준수하는가?
  • 빌드가 되는 코드인가요?
  • 버그가 발생하지 않는지 충분히 테스트 해봤나요?

작업 내용:

  • 홈 화면 prepareForReuse() 생성
  • 홈 화면 초기에서 title을 빈 문자열으로 수정
  • 열어본 횟수가 가장 많은 캡슐

이번에 공들였던 부분:

ex. firebase rest api 구현

이것저것이 어려웠는데 이렇게 해서 저렇게 해결하였다.

@solbat solbat added bug Something isn't working review labels Dec 12, 2022
@solbat solbat requested a review from pyj9748 December 12, 2022 08:52
@solbat solbat self-assigned this Dec 12, 2022
pyj9748
pyj9748 approved these changes Dec 12, 2022
View reviewed changes
SpaceCapsule/SpaceCapsule/Scene/TabBar/Home/HomeView.swift
text: "none님의 공간캡슐 10개",
text: "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text 파라미터 안 넣어도 됍니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 알겠습니다!

@pyj9748
Copy link
Collaborator

pyj9748 commented Dec 12, 2022

수고 하셨습니다!

@pyj9748 pyj9748 merged commit 1608ffe into develop Dec 12, 2022
solbat added a commit that referenced this pull request Dec 12, 2022
@solbat
[fix] ThemeLabel 생성 시 text 파라미터 제거 (#109)
4349563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyj9748 pyj9748 pyj9748 approved these changes

Assignees

@solbat solbat

Labels
bug Something isn't working review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solbat @pyj9748