회원 탈퇴 애플토큰 revoke 구현 #106
Merged
회원 탈퇴 애플토큰 revoke 구현 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trumanfromkorea
approved these changes
Dec 12, 2022
Comment on lines
+13
to
+43
| struct Header: Encodable { | ||
| let alg = "ES256" | ||
| let kid = "4979Z7MUXJ" | ||
| } | ||
|
|
||
| struct Payload: Claims { | ||
| var iss = "4G6ZD4247R" | ||
| var iat = Date().epochIATTimeStamp | ||
| var exp = Date().epochEXPTimeStamp | ||
| var aud = "https://appleid.apple.com" | ||
| var sub = "com.boostcamp.BoogieSpaceCapsule" | ||
| } | ||
|
|
||
| struct RefreshTokenResponse: Decodable { | ||
| let accessToken: String? | ||
| let refreshToken: String? | ||
| let idToken: String? | ||
|
|
||
| init(from decoder: Decoder) throws { | ||
| let values = try decoder.container(keyedBy: CodingKeys.self) | ||
| accessToken = try? values.decode(String.self, forKey: .accessToken) | ||
| refreshToken = try? values.decode(String.self, forKey: .refreshToken) | ||
| idToken = try? values.decode(String.self, forKey: .idToken) | ||
| } | ||
|
|
||
| enum CodingKeys: String, CodingKey { | ||
| case accessToken = "access_token" | ||
| case refreshToken = "refresh_token" | ||
| case idToken = "id_token" | ||
| } | ||
| } |
Comment on lines
+73
to
+76
| if let error = error { | ||
| print(error.localizedDescription) | ||
| completion(error) | ||
| } else { |
There was a problem hiding this comment.
guard let 쓰면 아래 코드 indent 가 줄어들어서 가독성이 더 좋을 것 같아용 ㅎㅎ
Comment on lines
+46
to
+56
| func downloadAuthP8(urlString: String, completion: @escaping (Data?) -> Void) { | ||
| let storageReference = storage.reference(forURL: urlString) | ||
| let megaByte = Int64(1 * 1024 * 1024) | ||
| storageReference.getData(maxSize: megaByte) { data, _ in | ||
| guard let data = data else { | ||
| completion(nil) | ||
| return | ||
| } | ||
| completion(data) | ||
| } | ||
| } |
Comment on lines
+208
to
+251
| private func sha256(_ input: String) -> String { | ||
| let inputData = Data(input.utf8) | ||
| let hashedData = SHA256.hash(data: inputData) | ||
| let hashString = hashedData.compactMap { | ||
| String(format: "%02x", $0) | ||
| }.joined() | ||
|
|
||
| return hashString | ||
| } | ||
|
|
||
| // Adapted from https://auth0.com/docs/api-auth/tutorials/nonce#generate-a-cryptographically-random-nonce | ||
| private func randomNonceString(length: Int = 32) -> String { | ||
| precondition(length > 0) | ||
| let charset: [Character] = | ||
| Array("0123456789ABCDEFGHIJKLMNOPQRSTUVXYZabcdefghijklmnopqrstuvwxyz-._") | ||
| var result = "" | ||
| var remainingLength = length | ||
|
|
||
| while remainingLength > 0 { | ||
| let randoms: [UInt8] = (0 ..< 16).map { _ in | ||
| var random: UInt8 = 0 | ||
| let errorCode = SecRandomCopyBytes(kSecRandomDefault, 1, &random) | ||
| if errorCode != errSecSuccess { | ||
| fatalError( | ||
| "Unable to generate nonce. SecRandomCopyBytes failed with OSStatus \(errorCode)" | ||
| ) | ||
| } | ||
| return random | ||
| } | ||
|
|
||
| randoms.forEach { random in | ||
| if remainingLength == 0 { | ||
| return | ||
| } | ||
|
|
||
| if random < charset.count { | ||
| result.append(charset[Int(random)]) | ||
| remainingLength -= 1 | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return result | ||
| } |
There was a problem hiding this comment.
중복되는 부분은 분리해주세요!
VC 에서도 분리하면 좋을것 같아요
Comment on lines
+105
to
+139
| var requestBodyComponents = URLComponents() | ||
| requestBodyComponents.queryItems = [ | ||
| URLQueryItem(name: "token", value: refreshToken), | ||
| URLQueryItem(name: "client_id", value: "com.boostcamp.BoogieSpaceCapsule"), | ||
| URLQueryItem(name: "client_secret", value: clientSecret), | ||
| URLQueryItem(name: "token_type_hint", value: "refresh_token"), | ||
| ] | ||
| var request = URLRequest(url: url) | ||
| request.httpMethod = "POST" | ||
| request.allHTTPHeaderFields = header | ||
| request.httpBody = requestBodyComponents.query?.data(using: .utf8) | ||
|
|
||
| let task = URLSession.shared.dataTask(with: request) { _, response, error in | ||
| if let error = error { | ||
| print(error.localizedDescription) | ||
| return | ||
| } | ||
| } | ||
| auth.currentUser?.delete { error in | ||
| if let response = response as? HTTPURLResponse { | ||
| print(response.description) | ||
| if response.statusCode == 200 { | ||
| completion(nil) | ||
| return | ||
| } else { | ||
| completion(ECError.failedEvpInit) // TODO: | ||
| return | ||
| } | ||
| } | ||
| if let error = error { | ||
| print(error.localizedDescription) | ||
| completion(error) | ||
| } else { | ||
| completion(nil) | ||
| } | ||
| } | ||
| task.resume() |
There was a problem hiding this comment.
요청하는 부분도 중복되서 간편화 하면 좋을것 같긴 한데
나중에 저랑 같이해요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제출 전 필수 확인 사항:
작업 내용:
이번에 공들였던 부분:
JWT Valid 한지 확인하기 위해 학습하는 부분이 어려웠습니다.