[밀봉/개봉 화면] 버그 수정 #104
Merged
[밀봉/개봉 화면] 버그 수정 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trumanfromkorea
approved these changes
Dec 12, 2022
| @@ -10,9 +10,9 @@ import SnapKit | |||
| import UIKit | |||
|
|
|||
| final class CapsuleOpenView: UIView, BaseView, UnOpenable { | |||
| lazy var thumbnailImageView = ThemeThumbnailImageView(frame: .zero, width: FrameResource.capsuleThumbnailWidth) | |||
| var thumbnailImageView = ThemeThumbnailImageView(frame: .zero, width: UIScreen.main.bounds.width * FrameResource.capsuleThumbnailWidthRatio) | |||
| let lockImageView = UIImageView() | ||
| lockImageView.image = .lock | ||
| lockImageView.tintColor = .themeGray200 | ||
| return lockImageView | ||
| }() | ||
|
|
||
| lazy var dateLabel = { | ||
| var dateLabel = { | ||
| let dateLabel = ThemeLabel(text: nil, size: FrameResource.fontSize80, color: .themeGray200) | ||
| dateLabel.textAlignment = .center | ||
| return dateLabel |
There was a problem hiding this comment.
불필요한 lazy 키워드 제거한거 좋네요
이왕 하시는 김에 불필요한 var 은 let 으로, 또 다른 객체에서 참조되지 않을 Label 들 같은 프로퍼티들은 private 으로 선언하면 더 좋을 것 같다는 의견입니당 ㅋㅅㅋ
There was a problem hiding this comment.
UnOpenabel 프로토콜의 속성들이라서 var를 사용했습니다.
Comment on lines
-107
to
+110
| $0.top.equalTo(self.snp.centerY).multipliedBy(0.8).offset(FrameResource.openCapsuleVerticalPadding + FrameResource.capsuleThumbnailHeight / 2) | ||
| $0.top.equalTo(self.snp.centerY).multipliedBy(0.7) | ||
| .offset(FrameResource.capsuleThumbnailHeight / 2 + AnimationResource.capsuleMoveHeight) | ||
| $0.bottom.equalTo(openButton.snp.top).offset(-FrameResource.spacing200).priority(999) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제출 전 필수 확인 사항:
작업 내용: