Merge pull request #92 from boostcampwm-2022/feature_capsuleDetail

캡슐 상세화면 버그 수정
boostcampwm-2022 · Dec 8, 2022 · 405edff · 405edff
2 parents d388b57 + 4ec614e
commit 405edff
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 5 deletions.
diff --git a/SpaceCapsule/SpaceCapsule/Resources/FrameResource.swift b/SpaceCapsule/SpaceCapsule/Resources/FrameResource.swift
@@ -97,4 +97,5 @@ enum FrameResource {
 
     static let detailSettingButtonHeight: CGFloat = 60.0
     static let detailSettingButtonPadding: CGFloat = 10.0
+    static let detailMainStackViewHPadding: CGFloat = 30.0
 }
diff --git a/SpaceCapsule/SpaceCapsule/Scene/TabBar/CapsuleAccess/CapsuleDetail/CapsuleDetailView.swift b/SpaceCapsule/SpaceCapsule/Scene/TabBar/CapsuleAccess/CapsuleDetail/CapsuleDetailView.swift
@@ -37,6 +37,7 @@ final class CapsuleDetailView: UIView, BaseView {
         collectionView.alwaysBounceHorizontal = true
         collectionView.backgroundColor = .clear
         collectionView.alwaysBounceHorizontal = false
+        collectionView.alwaysBounceVertical = false
         collectionView.showsHorizontalScrollIndicator = false
 
         return collectionView
@@ -116,7 +117,8 @@ final class CapsuleDetailView: UIView, BaseView {
 
     func makeConstraints() {
         mainStackView.snp.makeConstraints {
-            $0.edges.equalToSuperview()
+            $0.left.right.equalToSuperview()
+            $0.top.bottom.equalToSuperview().inset(FrameResource.detailMainStackViewHPadding)
         }
 
         imageCollectionView.snp.makeConstraints {
@@ -139,12 +141,17 @@ final class CapsuleDetailView: UIView, BaseView {
     }
 
     private func createLayout() -> UICollectionViewLayout {
-        let itemSize = NSCollectionLayoutSize(widthDimension: .fractionalWidth(1),
-                                              heightDimension: .fractionalHeight(1))
+        let itemSize = NSCollectionLayoutSize(
+            widthDimension: .fractionalWidth(1),
+            heightDimension: .fractionalHeight(1)
+        )
 
         let item = NSCollectionLayoutItem(layoutSize: itemSize)
 
-        let groupSize = NSCollectionLayoutSize(widthDimension: .absolute(FrameResource.detailImageViewWidth), heightDimension: .absolute(FrameResource.detailImageViewHeight))
+        let groupSize = NSCollectionLayoutSize(
+            widthDimension: .absolute(FrameResource.detailImageViewWidth),
+            heightDimension: .absolute(FrameResource.detailImageViewHeight)
+        )
 
         let group = NSCollectionLayoutGroup.horizontal(layoutSize: groupSize, subitems: [item])
 

diff --git a/...e/SpaceCapsule/Scene/TabBar/CapsuleAccess/CapsuleDetail/CapsuleDetailViewController.swift b/...e/SpaceCapsule/Scene/TabBar/CapsuleAccess/CapsuleDetail/CapsuleDetailViewController.swift
@@ -108,7 +108,7 @@ final class CapsuleDetailViewController: UIViewController, BaseViewController {
                 return UICollectionViewCell()
             }
 
-            cell.imageView.kr.setImage(with: item.imageURL, placeholder: .empty, scale: 1.0)
+            cell.imageView.kr.setImage(with: item.imageURL, placeholder: .empty, scale: FrameResource.openableImageScale)
 
             if let info = item.capsuleInfo {
                 cell.addCapsuleInfo(info)

diff --git a/...e/SpaceCapsule/Scene/TabBar/CapsuleAccess/CapsuleDetail/Componenets/DetailImageCell.swift b/...e/SpaceCapsule/Scene/TabBar/CapsuleAccess/CapsuleDetail/Componenets/DetailImageCell.swift
@@ -72,6 +72,13 @@ final class DetailImageCell: UICollectionViewCell {
         fatalError("init(coder:) has not been implemented")
     }
 
+    override func prepareForReuse() {
+        super.prepareForReuse()
+        imageView.image = nil
+        gradientView.removeFromSuperview()
+        capsuleInfoStackView.removeFromSuperview()
+    }
+
     private func configure() {
         contentView.layer.cornerRadius = FrameResource.commonCornerRadius
         contentView.layer.masksToBounds = true