모먼트 삭제 기능 구현 #91
Merged
모먼트 삭제 기능 구현 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaemin-Yoo
added
✨ feature
jhg3410
approved these changes
Dec 8, 2022
Comment on lines
+43
to
+44
| ) | ||
| .apply { _isReady.value = true } |
BBongKim
approved these changes
Dec 8, 2022
| scope = viewModelScope, | ||
| started = SharingStarted.WhileSubscribed(5000), | ||
| initialValue = emptyList() | ||
| ) |
There was a problem hiding this comment.
밑에 Paging 처리해서 가져온 변수가 StateFlow 로 정의 되어있어서 똑같이 저런 식으로 해둔건데 사실 큰 의미는 없습니다!!!!!!!!!!!!!!!!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Issue #14
👨🔧 개요
모먼트 삭제 기능 구현 / UiState 적용
📝 작업 내용
BroadCastReceiver를 통해 이벤트를 발생시켰는데 DB에 변경사항이 있을 때 자동으로 리스트 갱신 방식으로 변경 (그러나 사소한 이슈 발생 모먼트 남기기 시 바텀시트 최신순 정렬, 스크롤 맨 위로 올리기 #90 )📢 특이 사항
모먼트 수정부분까지하면 수정 내용 길어질까봐 여기까지해서 PR 올립니다 :)