Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Layer에서 ViewModelScope를 사용하지 않도록 변경 #94

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Data Layer에서 ViewModelScope를 사용하지 않도록 변경 #94

merged 6 commits into from
Dec 12, 2022

Conversation

soopeach
Copy link
Member

@soopeach soopeach commented Dec 10, 2022 •
edited
Loading

😎 작업 내용

  • Data Layer에서 ViewModelScope를 사용하지 않도록 변경
  • IODispatcher를 주입하는 모듈 추가
  • FIrestore 관련 로직 일부 수정

🧐 변경된 내용

  • DataSource에서 직접 코루틴 스코프를 관리하도록 변경
  • 단순(그룹 정보) flow FireStore에서 제공해주는 snapshots()을 사용하도록 변경
    내부적으로 callbackFlow로 구현되어있음
  • 운동 종료 알림도 snapshots()를 사용하도록 변경
  • flow가 종료되면 snapshotListener들의 등록을 해제하도록 변경
  • 불필요한 withContext 일부제거
    • RunningHistoryRemoteDataSourceImpl의 uploadRunningHistory() 메서드는 일시적인 오류인지..
      호출이 우선 잘 안되는 것 같아서 제외했습니다.

🥳 동작 화면

  • 동작 화면 없음

🤯 이슈 번호

  • 이슈 없음

🥲 비고

bngsh
bngsh approved these changes Dec 12, 2022
View reviewed changes
data/src/main/java/com/whyranoid/data/di/DispatchersQualifiers.kt

@Retention(AnnotationRetention.RUNTIME)
@Qualifier
annotation class IODispatcher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

annotation class가 뭔가요..

@soopeach soopeach merged commit 4b85567 into develop Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonghanJu yonghanJu yonghanJu approved these changes

@bngsh bngsh bngsh approved these changes

@peter-j0y peter-j0y peter-j0y approved these changes

Assignees
No one assigned
Labels
리뷰완료 현수
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soopeach @peter-j0y @bngsh @yonghanJu