♻️ 문자열 상수로 변경, 취소 가능한 서스펜드 변경 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bngsh
approved these changes
Dec 8, 2022
| @@ -26,9 +26,9 @@ class RunnerDataSourceImpl(private val db: FirebaseFirestore) : RunnerDataSource | |||
|
|
|||
| override suspend fun startRunning(uid: String): Boolean { | |||
| if (uid.isBlank()) return false | |||
| return suspendCoroutine { continuation -> | |||
| return suspendCancellableCoroutine { continuation -> | |||
There was a problem hiding this comment.
혹시.....cancellable일 때 뭐가 더 좋은건지 다시 설명해주실 수 있을까요.............불량학생이라 죄송합니다 교수님...
There was a problem hiding this comment.
공식 문서에서 prompt cancellation guarantee 라고 표현하는데요.
일시 중단된 동안 현재 코루틴의 작업이 취소된 경우 작업 재개하지 않고 중단하게 됩니다!
peter-j0y
approved these changes
Dec 9, 2022
| @@ -26,9 +26,9 @@ class RunnerDataSourceImpl(private val db: FirebaseFirestore) : RunnerDataSource | |||
|
|
|||
| override suspend fun startRunning(uid: String): Boolean { | |||
| if (uid.isBlank()) return false | |||
| return suspendCoroutine { continuation -> | |||
| return suspendCancellableCoroutine { continuation -> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🤯 이슈 번호