snack bar 확장함수 추가, 캘린더 버그 수정 및 연도 표시 추가 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bngsh
approved these changes
Dec 8, 2022
| @@ -36,44 +32,21 @@ class CalendarDayBinder( | |||
| R.color.gray | |||
| ) | |||
| ) | |||
| // day.day와 day.date.monthValue를 지정해서 특정 월, 일에 달렸다는 콩 표시 가능 | |||
| container.binding.root.background = null | |||
There was a problem hiding this comment.
혹시 여기가 버그 잡은 부분인건가요?! 어떻게 잡으신건지 궁금하네요👀
There was a problem hiding this comment.
리사이클러뷰가 재사용되어서 생겨서 콩이 찍히면 안되는 곳에 찍혔었는데 아이템마다 운동한 날짜인지 확인해서 운동한 날짜가 아니면 background를 null처리해주는 코드를 추가했습니다..!
| @@ -105,7 +105,7 @@ internal class RunningStartFragment : | |||
| if (GPSState.getGpsState(requireContext())) { | |||
| tryRunningStart() | |||
| } else { | |||
| Snackbar.make(binding.root, "gps 켜주세요", Snackbar.LENGTH_SHORT).show() | |||
| binding.root.makeSnackBar(getString(R.string.running_start_turn_on_gps)).show() | |||
soopeach
approved these changes
Dec 9, 2022
yonghanJu
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 작업 내용
🧐 변경된 내용
🥳 동작 화면
🤯 이슈 번호