Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shimmer관련 이슈 수정, 새로고침 기능 구현 #87

Merged
merged 4 commits into from
Dec 8, 2022

Conversation

soopeach
Copy link
Member

@soopeach soopeach commented Dec 8, 2022

😎 작업 내용

  • 위에서 아래로 스와이프하여 게시글, 내가 쓴 글을 새로고침하는 기능 구현

🧐 변경된 내용

  • shimmer가 기존의 게시물과 같이 보이던 이슈 수정

🥳 동작 화면

refresh

🤯 이슈 번호

binding.swipeRefreshLayout.apply {
setOnRefreshListener {
postAdapter.refresh()
binding.rvCommunity.scrollToPosition(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

companion object로 상수로 빼면 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다..!!

@bngsh bngsh linked an issue Dec 8, 2022 that may be closed by this pull request
Copy link
Collaborator

@bngsh bngsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@soopeach soopeach merged commit 63a825a into develop Dec 8, 2022
@soopeach soopeach deleted the feat/swipeRefresh branch December 10, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

기존 화면 + 시머가 같이 보이는 버그 발생
4 participants