Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunningActivity 생명주기 관찰 옵저버 생성 #83

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

yonghanJu
Copy link
Member

😎 작업 내용

  • RunningActivity 생명주기 관찰 옵저버 생성

🧐 변경된 내용

  • RunningActivity 가 생명주기 함수를 직접 오버라이딩하는 대신 옵저버를 생성

🥳 동작 화면

  • 동작 화면 없음

🤯 이슈 번호

  • 이슈 없음

Copy link
Member

@soopeach soopeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훨씬 깔끔하고 보기가 좋네요!!

this.onBackPressedDispatcher.addCallback(this, backPressedCallback)
lifecycle.addObserver(RunningActivityObserver(mapView, savedInstanceState))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호라... 엑티비티의 lifecycleOwner에 옵저버를 부착해주는거군요??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 훨씬 깔끔하네요! 이런 방법이 있군요?

Copy link
Member

@peter-j0y peter-j0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로운 방법을 배우고 갑니다!

this.onBackPressedDispatcher.addCallback(this, backPressedCallback)
lifecycle.addObserver(RunningActivityObserver(mapView, savedInstanceState))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 훨씬 깔끔하네요! 이런 방법이 있군요?

@yonghanJu yonghanJu merged commit e791eb0 into develop Dec 8, 2022
@soopeach soopeach deleted the feat/running_tab branch December 8, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants