Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further refactoring. #438

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Further refactoring. #438

merged 1 commit into from
Dec 1, 2022

Conversation

grzkv
Copy link
Member

@grzkv grzkv commented Dec 1, 2022

What issue is this change attempting to solve?

  • Extracted tldcache package.
  • Moved the expr package to the pkg directory; and now all packages are in that directory. It makes the project organization conformant to the standard project layout.

Contributes to #436 #432 #433

How can we be sure this works as expected?

Tested locally and on live traffic.

@grzkv grzkv merged commit e1039cc into master Dec 1, 2022
@grzkv grzkv deleted the grzkv/refactoring_packages branch December 1, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniszh deniszh deniszh approved these changes

@timtofan timtofan Awaiting requested review from timtofan timtofan is a code owner

@azhiltsov azhiltsov Awaiting requested review from azhiltsov azhiltsov is a code owner

@auguzun auguzun Awaiting requested review from auguzun

@emadolsky emadolsky Awaiting requested review from emadolsky emadolsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grzkv @deniszh