Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: autocomplete command with tab #492

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

Giuliano1993
Copy link
Contributor

This PR aims to close issue #440
Now pressing Tab when you have typed part of the command will autocomplete it with the first valid occurrence!

@Giuliano1993
Copy link
Contributor Author

Hi @bony2023 ! I added the needed test for the autocomplete functionality.
It should do the trick but, because a chain of deprecation and errors couldn't actually run the test, for none of the test using react from @testing-library/react is passing ( somehow some part of it isn't well installed, and some other features are being deprecated )
I leave you a screenshot for this error if you have any idea about it:
Screenshot 2024-06-07 103509

If you faced this issue previously and can give me an idea on how to go passed this and write a better test it would be great; otherwise if tests are just running for you, this one I wrote is pretty linear and shall be working!
Let me know!

@bony2023
Copy link
Owner

bony2023 commented Jun 9, 2024

Thanks @Giuliano1993 for flagging the failing tests! I am not sure when this started happening, but I can try taking a look and fix them in a different PR. The code looks good to me, I am hoping that the CI should take care of testing the logic and once green I can merge this one.

@bony2023 bony2023 merged commit ec950df into bony2023:main Jun 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants