Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update the qiime2 distro and update Codecov version to v4 #75

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Apr 19, 2024

Closes #74

  • Updated qiime2 distro in GitHub workflow file.
  • Added codecov token to GitHub workflow file.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (46ddd3f) to head (c8e5459).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   93.07%   93.53%   +0.45%     
==========================================
  Files          18       20       +2     
  Lines        1227     1314      +87     
==========================================
+ Hits         1142     1229      +87     
  Misses         85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VinzentRisch VinzentRisch requested a review from misialq April 19, 2024 09:15
@VinzentRisch
Copy link
Collaborator Author

Hi @misialq :)
can you approve this?

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch, could you maybe update the codecov action to v4 here and then just merge this (given that everything passes)?

@VinzentRisch VinzentRisch changed the title CI: Update the qiime2 distro CI: Update the qiime2 distro and update Codecov version to v4 Apr 23, 2024
@VinzentRisch VinzentRisch merged commit dc1041c into bokulich-lab:main Apr 23, 2024
8 checks passed
@VinzentRisch VinzentRisch deleted the 74_ci_update branch April 23, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: The name of the qiime2 distro has changed and has to be updated
2 participants