Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Added sample_dict to CARDAlleleAnnotationDirectoryFormat , CARDGeneAnnotationDirectoryFormat and CARDAnnotationDirectoryFormat #59

Merged
merged 4 commits into from
Mar 26, 2024
Merged

ENH: Added sample_dict to CARDAlleleAnnotationDirectoryFormat , CARDGeneAnnotationDirectoryFormat and CARDAnnotationDirectoryFormat #59

merged 4 commits into from
Mar 26, 2024

Conversation

VinzentRisch
Copy link
Collaborator

  • Added sample_dict function to CARDAlleleAnnotationDirectoryFormat , CARDGeneAnnotationDirectoryFormat and CARDAnnotationDirectoryFormat
  • This function returns a dict where keys are sample names and values are paths to the annotation files.

@VinzentRisch VinzentRisch requested a review from misialq March 21, 2024 16:12
misialq
misialq requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch, looks good! See some small suggestions below, otherwise seems alright 😄

q2_amr/types/_format.py Outdated Show resolved Hide resolved
q2_amr/types/_format.py Outdated Show resolved Hide resolved
q2_amr/types/_format.py Outdated Show resolved Hide resolved
q2_amr/types/tests/test_types_formats_transformers.py Outdated Show resolved Hide resolved
q2_amr/types/tests/test_types_formats_transformers.py Outdated Show resolved Hide resolved
@VinzentRisch
Copy link
Collaborator Author

Hi @misialq
Sorry for all the loops, will avoid this in the future :)

@VinzentRisch VinzentRisch requested a review from misialq March 22, 2024 08:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (0e1d37a) to head (e7eb72c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   92.78%   93.07%   +0.28%     
==========================================
  Files          18       18              
  Lines        1192     1227      +35     
==========================================
+ Hits         1106     1142      +36     
+ Misses         86       85       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

misialq
misialq approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @VinzentRisch! Feel free to merge whenever ready :)

@VinzentRisch VinzentRisch merged commit 46ddd3f into bokulich-lab:main Mar 26, 2024
6 checks passed
@VinzentRisch VinzentRisch deleted the 58_add_sample_dict branch March 26, 2024 13:12
@VinzentRisch VinzentRisch linked an issue Apr 5, 2024 that may be closed by this pull request
ENH: Add sample_dict function to classes CARDAlleleAnnotationDirectoryFormat, CARDAlleleAnnotationDirectoryFormat and CARDAnnotationDirectoryFormat #58
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misialq misialq misialq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VinzentRisch @codecov-commenter @misialq