-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added actions that can partition annotation artifacts from reads and MAGs. #54
Conversation
Hi @misialq |
Hey @misialq |
Hey @VinzentRisch, on the CI: it seems like the conda channel for the 2024.5 distro does not exist yet so I'd say it's related to the new release. |
Good Morning @misialq |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 93.89% 94.29% +0.40%
==========================================
Files 20 20
Lines 1393 1491 +98
==========================================
+ Hits 1308 1406 +98
Misses 85 85 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Michal Ziemski <[email protected]>
Co-authored-by: Michal Ziemski <[email protected]>
bb0c434
to
d9cb04a
Compare
This reverts commit 3f9b84d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VinzentRisch, see some suggestions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VinzentRisch, some more suggestions floating your way - mostly about readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VinzentRisch, I think this looks pretty good now! I just had a little realization - see below. This is the last comment on this one, promise!
This reverts commit cf38eff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @VinzentRisch! Merge away 🚀
Perfect! |
Oh, yeah, sure thing! |
This PR closes #53
partition-reads-gene-annotations
,partition-reads-allele-annotations
andpartition-mags-annotations
actions.SampleData[CARDAnnotation]
,SampleData[CARDAlleleAnnotation]
andSampleData[CARDAnnotation]
into a collection of a specified number of partitions with the same type.Set up an environment for intel
Run it locally
Download test files
PR-54.zip
Test it out!
SampleData[CARDGeneAnnotation % Properties('kma')]